Fix #1517: UnnecessaryLocalRule for variable in a try-catch-with-resources statement#1518
Draft
subha0319 wants to merge 1 commit intoyegor256:masterfrom
Draft
Fix #1517: UnnecessaryLocalRule for variable in a try-catch-with-resources statement#1518subha0319 wants to merge 1 commit intoyegor256:masterfrom
subha0319 wants to merge 1 commit intoyegor256:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1517
The Problem:
UnnecessaryLocalRulewas incorrectly flagging variables declared in atry-with-resourcesblock as unnecessary if they were only referenced once inside the block. These variables cannot be inlined because they are required by Java syntax to ensure the resource is auto-closed.The Solution:
Modified
UnnecessaryLocalRule.javato check if the evaluatedASTVariableDeclaratoris a descendant of anASTResourcenode. If it is, the visitor returns early and ignores the variable.Checklist
UnnecessaryLocalRule.javato ignoreASTResourcevariables.try-with-resourcesscenario.mvn clean installlocally and all static analysis checks and tests pass successfully.